[WIP] Add an extension for OpenID-based authentication.

Review Request #5199 — Created Jan. 6, 2014 and updated

chipx86
rb-extension-pack
master
reviewboard
puiterwijk

[WIP] Add an extension for OpenID-based authentication.

This introduces OpenID-based authentication to Review Board 2.0. It
extends the login page to provide options for logging in using common
services, such as GitHub or Google. It accepts any OpenID provider.

This is still a work-in-progress. It needs the in-development
Review Board 2.0 beta 2 changes, and doesn't yet provide anything for
the My Account page. There's still documentation missing, some debug
output, and more testing that needs to be done.

This is heavily based on the work done by Patrick Uiterwijk.

Tested logging in with different services.

Description From Last Updated

Do we want to localize these?

daviddavid

How about instead of having the add parameter, we pass in the siteconfig key, and move the self.settings.get() call into ...

daviddavid

Mark for translation.

daviddavid

Mark for translation.

daviddavid

<i> seems like an odd choice. Why not span?

daviddavid

Mark for translation.

daviddavid
david
  1. 
      
  2. rbsocialauth/rbsocialauth/extension.py (Diff revision 1)
     
     
     
     

    Do we want to localize these?

  3. rbsocialauth/rbsocialauth/extension.py (Diff revision 1)
     
     

    How about instead of having the add parameter, we pass in the siteconfig key, and move the self.settings.get() call into this method?

    It might also make sense to then rename this to be something like _apply_settings. It took me a while to figure out what this method name meant.

  4. Mark for translation.

  5. <i> seems like an odd choice. Why not span?

    1. Agreed. That's what Font Awesome says to use.

      http://fortawesome.github.io/Font-Awesome/examples/

      Turns out this is mirroring Bootstrap's glyphicons.

      However, I see nothing in the CSS that says it must be <i>, so I think I'll change it.

  6. 
      
Loading...