Summary

[WIP] Add an extension for OpenID-based authentication.

Review Request #5199 — Created Jan. 6, 2014 and updated Jan. 6, 2014, 1:57 p.m.

Information

Owner

chipx86

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

puiterwijk

Description

[WIP] Add an extension for OpenID-based authentication.

This introduces OpenID-based authentication to Review Board 2.0. It
extends the login page to provide options for logging in using common
services, such as GitHub or Google. It accepts any OpenID provider.

This is still a work-in-progress. It needs the in-development
Review Board 2.0 beta 2 changes, and doesn't yet provide anything for
the My Account page. There's still documentation missing, some debug
output, and more testing that needs to be done.

This is heavily based on the work done by Patrick Uiterwijk.

Testing Done

Tested logging in with different services.

Issues

Description	From	Last Updated
Do we want to localize these?	david	Feb. 21, 2014, 12:51 a.m.
How about instead of having the add parameter, we pass in the siteconfig key, and move the self.settings.get() call into …	david	Feb. 21, 2014, 1:01 a.m.
Mark for translation.	david	Feb. 21, 2014, 1:08 a.m.
Mark for translation.	david	Feb. 21, 2014, 1:08 a.m.
<i> seems like an odd choice. Why not span?	david	Feb. 21, 2014, 1:07 a.m.
Mark for translation.	david	Feb. 21, 2014, 1:08 a.m.

rbsocialauth/rbsocialauth/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Do we want to localize these?
```

rbsocialauth/rbsocialauth/extension.py (Diff revision 1)

The issue has been resolved. Show all issues

How about instead of having the add parameter, we pass in the siteconfig key, and move the self.settings.get() call into this method?

It might also make sense to then rename this to be something like _apply_settings. It took me a while to figure out what this method name meant.

rbsocialauth/rbsocialauth/templates/rbsocialauth/login.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Mark for translation.
```
rbsocialauth/rbsocialauth/templates/rbsocialauth/login.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Mark for translation.
```

rbsocialauth/rbsocialauth/templates/rbsocialauth/login.html (Diff revision 1)

The issue has been resolved. Show all issues

<i> seems like an odd choice. Why not span?

chipx86 Feb. 21, 2014, 1:08 a.m.

Agreed. That's what Font Awesome says to use.

http://fortawesome.github.io/Font-Awesome/examples/

Turns out this is mirroring Bootstrap's glyphicons.

However, I see nothing in the CSS that says it must be <i>, so I think I'll change it.

rbsocialauth/rbsocialauth/templates/rbsocialauth/login.html (Diff revision 1)
The issue has been resolved. Show all issues
```
Mark for translation.
```