Improve and fix parts of the inline editor widget.

Review Request #5194 — Created Jan. 4, 2014 and submitted

Information

Djblets
master

Reviewers

Improve and fix parts of the inline editor widget.

This adds some improvements to the widget, making it more useful to
consumers. A consumer can now get the button elements without having to
look in the DOM, and can also get the editing state. This helps with
making intelligent decisions involving the editor.

To improve the apparent responsiveness, the buttons no longer fade
in/out. This was fine to have for a while, but removing animation makes
the editor feel more snappy.

The editor also now forwards 'resize' events from the contained field to
the editor's element. This lets consumers see when autoSizeTextArea, or
a custom widget, has changed sizes, in order to do more intelligent
layout updates.

There was a bug with fading the pencil back in after editing was
completed. It was trying to fade to an opacity of 100, but really, it
should have faded to an opacity of 1.0. It looked like the pencil was
just instantly showing, because it was.

Tested that the pencil faded back in noticeably when completing editing.

Tested that buttons instantly appeared/disappeared when editing/completing.

Made use of the new resize event and accessors in a change in Review Board.

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...