-
-
-
reviewboard/scmtools/clearcase.py (Diff revision 1) Please make sure that all sentences start with a capital letter.
-
reviewboard/scmtools/clearcase.py (Diff revision 1) I'd rather import logging at the top of the file so we don't have to do it every time this method is called.
-
reviewboard/scmtools/clearcase.py (Diff revision 1) Please pass format arguments as additional arguments to
logging.*Please also make sure this wraps to 79 columns.
-
reviewboard/scmtools/clearcase.py (Diff revision 1) Please move the format arguments to be additional arguments to
logging.* -
reviewboard/scmtools/clearcase.py (Diff revision 1) The parentheses around the variable names aren't necessary.
-
-
reviewboard/scmtools/clearcase.py (Diff revision 1) Please pass format arguments as additional arguments to
logging.*. Otherwise it'll do two format operations. -
-
reviewboard/scmtools/clearcase.py (Diff revision 1) The parentheses around the variable names aren't necessary.
clearcase review requests often fail in multi-site mode because oid are not available yet on server (reviewboard)
Review Request #5185 — Created Jan. 3, 2014 and submitted
when people are submitting review request, oid of oldfile version and new file version are sent and used to retrieve file name.
However oldfile name is usually synced not but newfile one
Since filename is not mandatory, we can catch this exception and try to retrieve path from client filename and vob
create successfully review request before replica is sent
| Description | From | Last Updated |
|---|---|---|
|
Please wrap this to 79 columns. |
 david
|
|
|
Please make sure that all sentences start with a capital letter. |
david
|
|
|
I'd rather import logging at the top of the file so we don't have to do it every time this … |
david
|
|
|
Please pass format arguments as additional arguments to logging.* Please also make sure this wraps to 79 columns. |
david
|
|
|
Please move the format arguments to be additional arguments to logging.* |
david
|
|
|
The parentheses around the variable names aren't necessary. |
david
|
|
|
Please move the import to the top of the file. |
david
|
|
|
Please pass format arguments as additional arguments to logging.*. Otherwise it'll do two format operations. |
david
|
|
|
Idiomatic python would be while True: |
david
|
|
|
The parentheses around the variable names aren't necessary. |
david
|
|
|
Please keep these in alphabetical order. |
david
|
-
Oh, I also have a question about compatibility. Because there are both reviewboard and rbtools changes to fix this bug, is this code cross-compatible between versions? For example, if I'm using a Review Board instance with the code and RBTools without, or vice-versa, will things break?