clearcase review requests often fail in multi-site mode because oid are not available yet on server (rbtools)

Review Request #5184 — Created Jan. 3, 2014 and submitted

delyn
RBTools
master
3183
rbtools
jan.koprowski

replace revision /streamname/0 by their clearcase predecessor ie parentstream/N (N is origin revision of file in parent stream)
linked with https://reviews.reviewboard.org/r/5168

create clearcase review request using --ucm-activity in a fresh stream ie containing /streamname/0 versions

Description From Last Updated

'file' is a reserved word in python. This will work, but in order to be more correct, can we call ...

daviddavid

Sentences in comments should start with a capital letter and end in a period.

daviddavid

Please pass format arguments as additional arguments to logging.*

daviddavid

This looks like it could be one line and still be less than 79 columns.

daviddavid

Please pass format arguments as additional arguments to logging.*

daviddavid

Put a blank line between the first line of a docstring (the summary) and the rest. The final """ should ...

daviddavid

Please wrap this to 79 columns. Also, sentences in comments should start with a capital letter and end with a ...

daviddavid
DE
david
  1. 
      
  2. rbtools/clients/clearcase.py (Diff revision 1)
     
     

    'file' is a reserved word in python. This will work, but in order to be more correct, can we call this something like 'filename' or 'path'?

  3. rbtools/clients/clearcase.py (Diff revision 1)
     
     

    Sentences in comments should start with a capital letter and end in a period.

  4. rbtools/clients/clearcase.py (Diff revision 1)
     
     

    Please pass format arguments as additional arguments to logging.*

  5. rbtools/clients/clearcase.py (Diff revision 1)
     
     
     
     
     

    This looks like it could be one line and still be less than 79 columns.

    1. after renaming file to file_revision, it is now greater than 79 columns

  6. rbtools/clients/clearcase.py (Diff revision 1)
     
     

    Please pass format arguments as additional arguments to logging.*

  7. rbtools/clients/clearcase.py (Diff revision 1)
     
     
     
     

    Put a blank line between the first line of a docstring (the summary) and the rest.

    The final """ should also go on its own line.

  8. rbtools/clients/clearcase.py (Diff revision 1)
     
     

    Please wrap this to 79 columns. Also, sentences in comments should start with a capital letter and end with a period.

  9. 
      
DE
david
  1. Ship It!

  2. 
      
DE
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to rbtools master (2d2d387). Thanks!
Loading...