• 
      

    Filter out users not on the LocalSite when sending e-mails.

    Review Request #5181 — Created Jan. 2, 2014 and submitted

    Information

    Review Board
    release-1.7.x

    Reviewers

    Filter out users not on the LocalSite when sending e-mails.

    Users who were previously listed as a reviewer on a review request
    belonging to a LocalSite, or participated in the discussion, would
    continue to receive e-mails related to the review request after removed
    from the LocalSite. This isn't ideal, as they shouldn't have had any
    access once removed.

    We now filter out these users when sending an e-mail. Both the
    target_people list and the review participants are considered when
    filtering.

    Unit tests pass. Prior to this, the new unit test would fail, including
    the users not part of the LocalSite.

    Description From Last Updated

    get_email_addresses_for_group should do a similar filtering step.

    david david
    david
    1. 
        
    2. reviewboard/notifications/email.py (Diff revision 1)
       
       
       
      Show all issues

      get_email_addresses_for_group should do a similar filtering step.

    3. 
        
    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed