Summary

Use parsed revisions for 'cvs diff'

Review Request #5163 — Created Dec. 24, 2013 and submitted Dec. 27, 2013, 7:50 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Use parsed revisions for 'cvs diff'

This changes CVSClient.diff and .diff_between_revisions to use the results of
parse_revision_spec.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Just a nit, but I find it harder to read this than to do base != 'BASE' or tip != …	chipx86	Dec. 27, 2013, 7:46 a.m.

Expand All
Collapse All

rbtools/clients/cvs.py (Diff revision 1)

The issue has been dropped. Show all issues

Just a nit, but I find it harder to read this than to do base != 'BASE' or tip != self.REVISION_WORKING_COPY, since I have to invert the logic in my head. Not a major deal, so up to you.

Status:: Completed
Change Summary:: Pushed to master (d432b10)