Use parsed revisions for 'cvs diff'

Review Request #5163 — Created Dec. 24, 2013 and submitted

david
RBTools
master
rbtools

Use parsed revisions for 'cvs diff'

This changes CVSClient.diff and .diff_between_revisions to use the results of
parse_revision_spec.

Ran unit tests.

Description From Last Updated

Just a nit, but I find it harder to read this than to do base != 'BASE' or tip != …

chipx86chipx86
chipx86
  1. 
      
  2. rbtools/clients/cvs.py (Diff revision 1)
     
     
     

    Just a nit, but I find it harder to read this than to do base != 'BASE' or tip != self.REVISION_WORKING_COPY, since I have to invert the logic in my head. Not a major deal, so up to you.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (d432b10)
Loading...