cannot compare several couple of clearcase file revision using --revision-range




 


  Review Request #5154
  —
  Created Dec. 23, 2013 and discarded 

 















 
  
  
 




 
  

   Information

  

 
 

  

   
   
delyn


  


  

   
   
RBTools


  


  

   
   
master


  


  

   
   
3173


  


  

   
   



  


 



 
  

   Reviewers

  

 
 

  

   
   
rbtools


  


  

   
   



  


 











 

  
  


token delimiter ";" and zip does not allow to generate a list of revision range for do_diff




 




 

  
  


$ post-review --revision-range="file1@@/main/branch/1:file1@@/main/branch/2;file2@@/main/branch/1:file2@@/main/branch/5" --output-diff  |grep +++

+++ file1@@/main/branch/2     2013-06-06 10:04:01.000000000 +0200

+++ file2@@/main/branch/5     2013-06-19 09:36:13.000000000 +0200




 














 

 






 
 
 

  

   

    
   

   
    
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
   

  

  

   
    

     Description
     From
     Last Updated
    

   
   



    

     
      
      
Hi this is strange. Did you try split everything by ';' and do not use ':' as separator between two …

     		
     
      jan.koprowskijan.koprowski
     
     
      
     
    




    

     
      
      
Can you check that this split results in a 2-element list, and raise an error if not?

     		
     
      daviddavid
     
     
      
     
    


   
  

 












  

 








 














 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      rbtools/clients/clearcase.py
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Can you check that this split results in a 2-element list, and raise an error if not?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    Can you also change the documentation to explain that multiple file comparisons can be added by separating with ';' ?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




jan.koprowski




   

   







  

 



 

  


   

   

    
 
jan.koprowski


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      rbtools/clients/clearcase.py
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Hi this is strange. Did you try split everything by ';' and do not use ':' as separator between two versions of the same file? This should work.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      For me it looks like a bug in documentation not in the code:
      

      

      

      

      

      

      

      

      

      

      revision_range = 'a;b;c;d;e;f;g;h';                        
      
revision_range = 'a;b;c;d;e;f;g;h'.split(';');             
      
changeset = zip(revision_range[0::2], revision_range[1::2])
      
list(changeset)                                            
      
[('a', 'b'), ('c', 'd'), ('e', 'f'), ('g', 'h')]
      

      

      

      

      Replacing ':' by ';' in documentation solve the problem. Code still works properly.
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   





 DE





   

   





  

 



 

  


   

   

    
 
delyn


    
   


  

  

  



    




  1. 
 
    
  
    
   
    David, Jan,
    

    thank for you comments about delimiter...
    

    This review is useless because adding support for label comparision #5155 will not reuse this line anymore
    
I think I should discard it and concentrate on #5155
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 DE





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...