Summary

cannot compare several couple of clearcase file revision using --revision-range

Review Request #5154 — Created Dec. 23, 2013 and discarded Dec. 31, 2013, 12:34 a.m.

Information

Owner

delyn

Repository

RBTools

Branch

master

Bugs

3173

Depends On

Reviewers

Groups

rbtools

People

Description

token delimiter ";" and zip does not allow to generate a list of revision range for do_diff

Testing Done

$ post-review --revision-range="file1@@/main/branch/1:file1@@/main/branch/2;file2@@/main/branch/1:file2@@/main/branch/5" --output-diff  |grep +++

+++ file1@@/main/branch/2     2013-06-06 10:04:01.000000000 +0200

+++ file2@@/main/branch/5     2013-06-19 09:36:13.000000000 +0200

Issues

Description	From	Last Updated
Hi this is strange. Did you try split everything by ';' and do not use ':' as separator between two …	jan.koprowski	Dec. 23, 2013, 11:56 p.m.
Can you check that this split results in a 2-element list, and raise an error if not?	david	Dec. 23, 2013, 11:50 a.m.

Fix it!

rbtools/clients/clearcase.py (Diff revision 1)

An issue was opened. Show all issues

Can you check that this split results in a 2-element list, and raise an error if not?

Can you also change the documentation to explain that multiple file comparisons can be added by separating with ';' ?

Fix it!

rbtools/clients/clearcase.py (Diff revision 1)

An issue was opened. Show all issues

Hi this is strange. Did you try split everything by ';' and do not use ':' as separator between two versions of the same file? This should work.

jan.koprowski Dec. 24, 2013, 12:46 a.m.

For me it looks like a bug in documentation not in the code:









revision_range = 'a;b;c;d;e;f;g;h';                        

revision_range = 'a;b;c;d;e;f;g;h'.split(';');             

changeset = zip(revision_range[0::2], revision_range[1::2])

list(changeset)                                            

[('a', 'b'), ('c', 'd'), ('e', 'f'), ('g', 'h')]



Replacing ':' by ';' in documentation solve the problem. Code still works properly.

David, Jan,

thank for you comments about delimiter...

This review is useless because adding support for label comparision #5155 will not reuse this line anymore
I think I should discard it and concentrate on #5155

Status:: Discarded