Add support for the Unfuddle hosting service.

Review Request #5147 — Created Dec. 19, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Add support for the Unfuddle hosting service.

This supports Unfuddle as a hosting service. Unfuddle provides Git and
Subversion hosting.

Unfuddle's pretty straightforward to support. It makes use of HTTP Basic
Auth, and requires base commit IDs for posting.

There's also some improvements to RepositoryForm to provide more data to
the HostingService's authorize and check_repository functions.
The Unfuddle support uses this to do better validation of a repository
and an account, which we should make use of for other services.

Tried adding an account with bad credentials. Saw a reasonable error.

Added a valid account with no problems.

Tried to create a repository with bad repo info. Saw a reasonable error.

Created with valid info and it validated and saved. Tested this with Git and Subversion.

Posted diffs for both Git and Subversion. Both worked.

Description From Last Updated

When you merge this to master, can you switch this to use json from the stdlib?

daviddavid

This line looks like it might be too long?

daviddavid
chipx86
chipx86
david
  1. 
      
  2. reviewboard/hostingsvcs/unfuddle.py (Diff revision 3)
     
     

    When you merge this to master, can you switch this to use json from the stdlib?

  3. reviewboard/scmtools/forms.py (Diff revision 3)
     
     

    This line looks like it might be too long?

  4. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...