Add multi-select actions and visual improvements to the dashboard.

 






 

 


  Review Request #5144
  —
  Created Dec. 19, 2013 and submitted 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Add multi-select actions and visual improvements to the dashboard.


This is the first big update we've had to the dashboard in some time.


First, it adds support for multiple selection of review requests, and

actions that can be invoked for those that are selected. The actions

right now are limited to closing review requests, but more can be added

down the road.


The action pane appears over the sidebar. It's in a darker color and is

semi-transparent (but only barely). It goes away when no review requests

are selected.


This also makes the dashboard take up the full height of the page

(excluding some padding and the content above it). The rows of entries

scroll now, instead of having to scroll the entire page. With the new

changes to datagrids in Djblets, the rows are able to scroll without

affecting the header, meaning you can always see what column represents

what cell.

 








  


 
 

  
Tested in Chrome, Firefox, IE10, and IE 7/8/9 in IE10's compatibility modes.


Tested selecting and unselecting different numbers of review requests.


Tested selecting/unselecting all review requests.


Tested that changing columns or performing other operations that may mess

with selection (due to reloading the contents of the datagrid) cleared the

selection, removing the actions pane.


Tested closing review requests as discarded and as submitted, individually

and as groups.


Cleared the entire dashboard in one go with a close operation.


Tested that after performing an action, the contents of the dashboard

reloaded.


Tested with a review request I didn't have permission to close. Saw it handle

it gracefully and notify me that one couldn't be closed in the results dialog.

 







 









 





  








 

  
  


   

    

     

     

     

    

   


   

    

     

     

     

    

   


   

    

     

     

     

    

   


   

    

     

     

     

    

   


   

  

 







 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
This argument isn't used.

      		
      
       daviddavid
      
      
       
      
     




     

      
       
       
Leftover debug code?

      		
      
       daviddavid
      
      
       
      
     




     

      
       
       
.render() returns this, so you could chain this on to the previous statement if you wanted.

      		
      
       daviddavid
      
      
       
      
     


    
   

  

 







 






  

 








 














 



 

  

   




chipx86




   

   

  

 



 















 



 

  

   




chipx86




   

   

  

 



 















 



 

  

   




chipx86




   

   

  

 



 















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    This argument isn't used.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Leftover debug code?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      The code just wanted to be friendly.
      
 
      

      2. 


 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    .render() returns this, so you could chain this on to the previous statement if you wanted.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      You mean something like:
      

      (new RB.DashboardView({
    el: ...,
    model: ....
}))
   .render();

      

      ?
      

      While doable, I kind of dislike the whole (new ...).func() bit.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Sure, it's your call.
      
 
      

      3. 


 
    


    

 
    

    5. 




  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...