View review group members

Review Request #514 — Created Aug. 25, 2008 and submitted

Information

Review Board SVN (deprecated)

Reviewers

This one's a request from one of my users who wanted to see who's attending a group:
- Adds a member count column to the group datagrid.
- The new column links to a modified version of the submitter datagrid which only shows the members of the specified group.
Tested using my local test instance.
chipx86
  1. 
      
  2. /trunk/reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    2 blank lines before this.
  3. /trunk/reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    Does this fit in 80 columns?
    
    Wondering if it's bad at all to define this default value for User there. Probably okay I guess.
    1. I added some line-wraps so it won't be over 80 columns.
      The default values were added because I did not want to alter the behaviour of SubmitterDataGrid. Anything else would require an adjustment to the lines where SubmitterDataGrid is already used.
  4. /trunk/reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    The "=" should line up, and no space before the "(". Also, all params should line up with the first param.
  5. 
      
Loading...