Warn users about a dirty working directory.

Review Request #5132 — Created Dec. 17, 2013 and submitted

Information

RBTools
master

Reviewers

Warn users about a dirty working directory.

If a user posts a change with no revision arguments, they probably want their
"current" state to be the change. We've had a little bit of confusion with Git
users who hadn't committed their changes to a branch and were upset that their
working tree wasn't posted (like it would be with svn, for example).

This change adds a warning when the user invokes rbt post without explicit
revision arguments and has a dirty working directory.

Posted this change with some other stuff in my working directory and saw the
warning.

Description From Last Updated

We're using "review request" in other strings. Probably shouldn't capitalize it here.

chipx86chipx86
david
chipx86
  1. Awesome. I've been bitten by this.

    One small thing.

  2. rbtools/clients/git.py (Diff revision 1)
     
     
    Show all issues

    We're using "review request" in other strings. Probably shouldn't capitalize it here.

  3. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (66562bc).