Summary

Add support for Django 1.5's index_together property.

Review Request #5121 — Created Dec. 16, 2013 and submitted Dec. 16, 2013, 3:04 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

Add support for Django 1.5's index_together property.

Django 1.5 introduced index_together for creating an index that spans
columns without being unique. This provides support for that new
property through ChangeMeta.

Unlike with unique_together, we don't have old signature state to worry
about, so we can safely compare values and assume they're correct
(though the actual code to perform the index_together will still
sanity-check the database before generating error-prone SQL).

Testing Done

Unit tests pass.

Tested that it doesn't cause any issues with our existing evolutions.

Issues

Description	From	Last Updated
This indentation is very, very weird. How about: self.changed\ .setdefault(app_name, {})\ .setdefault('changed', {})\ .setdefault(model_name, {})\ .setdefault('meta_changed', [])\ .append('index_together')	david	Dec. 16, 2013, 2:35 p.m.

Testing Done:: ~
Unit tess pass.
~
Unit tests pass.

Tested that it doesn't cause any issues with our existing evolutions.

django_evolution/diff.py (Diff revision 1)

The issue has been dropped. Show all issues

This indentation is very, very weird.
How about:

self.changed\
    .setdefault(app_name, {})\
    .setdefault('changed', {})\
    .setdefault(model_name, {})\
    .setdefault('meta_changed', [])\
    .append('index_together')

chipx86

Dec. 16, 2013, 2:35 p.m.

Not wild about the backslashes. I think it actually looks less readable.
That said, I hate the current form too. It's used in a lot of places in this codebase. I planned to fix it in a separate change in one swoop. Basically, going to add a function that takes each part of that path as *args and loop through, doing the setdefault. Given that, going to drop this for now, and I'll put a new change up shortly.

Ship it!

```
Ship It!
```

Status:: Completed

~		Unit tess pass.
	~	Unit tests pass.

		Tested that it doesn't cause any issues with our existing evolutions.