Do some simple refactoring of the post command.

 






 

 


  Review Request #5118
  —
  Created Dec. 16, 2013 and submitted 

 


















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
Do some simple refactoring of the post command.


This change does some cleanup that struck me as I was reading through the post

implementation. I've moved the score matching out into a new utils file, and

rearranged/commented the argument evaluation a little bit.

 








  


 
 

  
    

  • Ran unit tests
    • 

  • Posted a change
    • 


 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Looks good.
    

    The only thing that stands out to me is that I have no idea how to use Score without going through the post code. It'd be nice if we could have the docstrings fleshed out a little more.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Sure. Done and pushed.
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (58ea479)





 


 










  

 









     

    

   

  

  

   
   Loading...