Support of Perforce Brokers

Review Request #5062 — Created Dec. 6, 2013 and submitted

Information

RBTools

Reviewers

Modification of Perforce client to support Perforce brokers. First check if the P4 Info has a Broker address defined .. if so use the broker, otherwise (as before) check the Server address.

Been using this mod for over a year at Cadence on RBTools 0.5.1

Description From Last Updated

Please change this to use only one # per line, and start the first setence ("first query") with a capital …

daviddavid

This can be removed, because it will fall through to line 175 which does this exact same thing.

daviddavid
david
  1. 
      
    1. Can you also cross-link the bug ID in this review request? Thanks!

    2. We're approaching an rbtools release, so I'm just going to clean up these issues and push it. Thanks!

  2. rbtools/clients/perforce.py (Diff revision 1)
     
     
     
     
     
    Show all issues

    Please change this to use only one # per line, and start the first setence ("first query") with a capital letter.

  3. rbtools/clients/perforce.py (Diff revision 1)
     
     
     
    Show all issues

    This can be removed, because it will fall through to line 175 which does this exact same thing.

  4. 
      
JM
  1. 
      
  2. rbtools/clients/perforce.py (Diff revision 1)
     
     
     
     
     

    Will do.

  3. rbtools/clients/perforce.py (Diff revision 1)
     
     
     

    Agreed.

  4. 
      
JM
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to rbtools release-0.5.x (3a78ad0). Thanks!
Loading...