Summary

Support of Perforce Brokers

Review Request #5062 — Created Dec. 6, 2013 and submitted Dec. 8, 2013, 8:11 p.m.

Information

Owner

jmarkham

Repository

RBTools

Branch

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Modification of Perforce client to support Perforce brokers. First check if the P4 Info has a Broker address defined .. if so use the broker, otherwise (as before) check the Server address.

Testing Done

Been using this mod for over a year at Cadence on RBTools 0.5.1

Issues

Description	From	Last Updated
Please change this to use only one # per line, and start the first setence ("first query") with a capital …	david	Dec. 8, 2013, 8:07 p.m.
This can be removed, because it will fall through to line 175 which does this exact same thing.	david	Dec. 8, 2013, 8:07 p.m.

david Dec. 6, 2013, 7:07 p.m.

Can you also cross-link the bug ID in this review request? Thanks!

david Dec. 8, 2013, 8:11 p.m.

We're approaching an rbtools release, so I'm just going to clean up these issues and push it. Thanks!

rbtools/clients/perforce.py (Diff revision 1)

Show all issues

Please change this to use only one # per line, and start the first setence ("first query") with a capital letter.

rbtools/clients/perforce.py (Diff revision 1)

Show all issues

This can be removed, because it will fall through to line 175 which does this exact same thing.

rbtools/clients/perforce.py (Diff revision 1)
```
Will do.
```
rbtools/clients/perforce.py (Diff revision 1)
```
Agreed.
```

Status: Closed (submitted)

Change Summary:

Pushed to rbtools release-0.5.x (3a78ad0). Thanks!