Factor out all common request fields for comment API resources.

Review Request #5044 — Created Dec. 2, 2013 and submitted

Information

Review Board
master

Reviewers

Factor out all common request fields for comment API resources.

There's a number of fields that are common between all the comment
resources' create/update requests. In order to reduce code duplication
and to make it easier to add or change these lists, I've pulled out
these common fields into a set of variables in BaseCommentResource that
can be reused.

Unit tests pass.

Description From Last Updated

Should we include localization for this and the other descriptions?

daviddavid
david
  1. 
      
  2. Show all issues

    Should we include localization for this and the other descriptions?

    1. We haven't for any API docs, and it's only used for doc generation. I'm not sure off-hand how we'd even make use of localized strings. I think that's a far bigger project.

  3. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...