Summary

Fix an exception in the API when accessing file attachments without review UIs.

Review Request #5032 — Created Nov. 27, 2013 and submitted Nov. 28, 2013, 10:29 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-1.7.x

Bugs

3145

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix an exception in the API when accessing file attachments without review UIs.

The thumbnail field in FileAttachment was accessing the review_ui without first
checking it for None-ness. Trivial fix.

Testing Done

Expand All
Collapse All

Can we get a unit test for this, to ensure it stays fixed?

david Nov. 28, 2013, 10:06 p.m.

We don't have equivalent tests for the other methods which have this if/else pattern, and it would be a somewhat fragile test given that at any point, a review UI could be added for whichever mimetype I choose.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (bce2d40).