rbwebhooks: Add support for some additional events

 






 

 


  Review Request #5027
  —
  Created Nov. 25, 2013 and discarded 

 


















 

  

   Information

  





 
 

  tchap
 









 
 

  rb-extension-pack
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
rbwebhooks: Add support for some additional events


Namely the events newly supported are review_request_closed,

review_request_reopened and review_request_approved.


The POST requests also contain additional header now that contains the event

that the request represents. The header is called X-ReviewBoard-Event.

 








  


 
 

  
I tested this by reading the server logs. It was failing for me just because the server was not reachable. Otherwise it looked ok, it should not throw any RB server errors...

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Should the logging.warning(...) be a part of the exception block itself, since we are interested in each attempt's exception? That …

      		
      
       
 EM
emerson.lancaster
      
      
       
      
     


    
   

  

 







 






  

 








 














 



 

  

   





 TC





   

   

  

 



 















 





 

  

   





 EM





   

   







  

 



 

  


   

   

    
 
emerson.lancaster


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       rbwebhooks/rbwebhooks/extension.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Should the logging.warning(...) be a part of the exception block itself, since we are interested in each attempt's exception?
    

    That would remove the err variable, too.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Yeah, makes sense. I somehow left what was there before without thinking too much...
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I fixed the open issue quite some time ago, could someone take a look on this patch again, please?
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   





 TC





   

   

  

 



 















 





 

  

   




david




   

   





  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Before I give detailed feedback on the code, I'd really like you to split this up into three separate review requests, one for doing the header stuff, one for basic auth (which is in the code but wasn't even in the description), and one for adding new events.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 TC





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Discarded

   

  




  

   

    Change Summary:
   

   

    
Seemingly abandoned.