Summary

rbwebhooks: Add support for some additional events

Review Request #5027 — Created Nov. 25, 2013 and discarded April 28, 2014, 2:33 p.m.

Information

Owner

tchap

Repository

rb-extension-pack

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

rbwebhooks: Add support for some additional events

Namely the events newly supported are review_request_closed,
review_request_reopened and review_request_approved.

The POST requests also contain additional header now that contains the event
that the request represents. The header is called X-ReviewBoard-Event.

Testing Done

I tested this by reading the server logs. It was failing for me just because the server was not reachable. Otherwise it looked ok, it should not throw any RB server errors...

Issues

Description	From	Last Updated
Should the logging.warning(...) be a part of the exception block itself, since we are interested in each attempt's exception? That …	EM emerson.lancaster	Nov. 26, 2013, 9:55 a.m.

rbwebhooks/rbwebhooks/extension.py (Diff revision 1)

The issue has been resolved. Show all issues

Should the logging.warning(...) be a part of the exception block itself, since we are interested in each attempt's exception?

That would remove the err variable, too.

tchap Nov. 26, 2013, 9:48 a.m.

Yeah, makes sense. I somehow left what was there before without thinking too much...

tchap Dec. 1, 2013, 2:56 p.m.

I fixed the open issue quite some time ago, could someone take a look on this patch again, please?

Diff:

Revision 2 (+82 -17)

Show changes

	rbwebhooks/setup.py
	rbwebhooks/rbwebhooks/extension.py
	rbwebhooks/rbwebhooks/forms.py
	rbwebhooks/rbwebhooks/handlers.py

Before I give detailed feedback on the code, I'd really like you to split this up into three separate review requests, one for doing the header stuff, one for basic auth (which is in the code but wasn't even in the description), and one for adding new events.

Status:: Discarded
Change Summary:: Seemingly abandoned.