Fish Trophy

david got a fish trophy!

Fish Trophy

Tweak markdown escaping to be less eager.

Review Request #5005 — Created Nov. 18, 2013 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

Tweak markdown escaping to be less eager.

The markdown escaping was still pretty overzealous, escaping -, +, and #
characters even when they didn't affect the markdown output. This made the
source text annoying to read.

I've made the regexes more complex to handle these cases.

  • Verified my assumptions about how these characters are treated in the source
    text.
  • Ran python and javascript unit tests.
reviewboard/reviews/markdown_utils.py
reviewboard/reviews/tests.py
reviewboard/static/rb/js/utils/textUtils.js
reviewboard/static/rb/js/utils/tests/textUtilsTests.js
Loading...