Split up files in djblets.util into new apps.

Review Request #4950 — Created Nov. 13, 2013 and submitted

Information

Djblets
master

Reviewers

Split up files in djblets.util into new apps.

djblets.util has become a dumping grounds of all sorts of random stuff.
In an effort to make things more manageable and future-proof, this
change moves out a lot of our code into new apps.

This change is backwards-compatible. The old files can still be imported
and will import the old classes and functions they provide, but will do
so with deprecation warnings. In Djblets 0.9, these will be removed.

There's also a few PyFlakes fixes I fixed while in the area.

  • Ran unit tests on Djblets and Review Board. Both passed.
  • Went through the files after the big unicode_literals change was merged in and made sure all the changes were replicated in the new files (pretty sure I got them all).
Description From Last Updated

Can we use underscores instead of bumpy caps?

daviddavid

Here too.

daviddavid

I'm not sure why this is called "memory.py". Care to elaborate?

daviddavid

underscores?

daviddavid

underscores?

daviddavid
david
  1. 
      
  2. djblets/cache/context_processors.py (Diff revision 1)
     
     
    Show all issues

    Can we use underscores instead of bumpy caps?

  3. djblets/cache/context_processors.py (Diff revision 1)
     
     
    Show all issues

    Here too.

  4. djblets/cache/memory.py (Diff revision 1)
     
     
    Show all issues

    I'm not sure why this is called "memory.py". Care to elaborate?

    1. As discussed in person, the idea was to convey this was for memory-based caching (locmem/memcached), as opposed to client-side/browser caching, or (possibly later) more specific things like redis-based caching.

      I'm open to suggestions on the naming.

    2. backend? server?

    3. I considered backend originally, but typically in Django apps, "backend" modules are internal and used to provide a backend to something, rather than being something you import from. I like it better than "server," though, since that feels more like a server implementation.

  5. Show all issues

    underscores?

  6. djblets/urls/context_processors.py (Diff revision 1)
     
     
    Show all issues

    underscores?

  7. 
      
chipx86
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...