Summary

Split up files in djblets.util into new apps.

Review Request #4950 — Created Nov. 13, 2013 and submitted Nov. 18, 2013, 12:28 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Split up files in djblets.util into new apps.
djblets.util has become a dumping grounds of all sorts of random stuff.

In an effort to make things more manageable and future-proof, this

change moves out a lot of our code into new apps.
This change is backwards-compatible. The old files can still be imported

and will import the old classes and functions they provide, but will do

so with deprecation warnings. In Djblets 0.9, these will be removed.
There's also a few PyFlakes fixes I fixed while in the area.

Testing Done


Ran unit tests on Djblets and Review Board. Both passed.
Went through the files after the big unicode_literals change was merged in and made sure all the changes were replicated in the new files (pretty sure I got them all).

Issues

Description	From	Last Updated
Can we use underscores instead of bumpy caps?	david	Nov. 17, 2013, 1:56 p.m.
Here too.	david	Nov. 17, 2013, 1:56 p.m.
I'm not sure why this is called "memory.py". Care to elaborate?	david	Nov. 17, 2013, 6:10 p.m.
underscores?	david	Nov. 17, 2013, 1:57 p.m.
underscores?	david	Nov. 17, 2013, 1:57 p.m.

djblets/cache/context_processors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we use underscores instead of bumpy caps?
```
djblets/cache/context_processors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Here too.
```

djblets/cache/memory.py (Diff revision 1)

The issue has been resolved. Show all issues

I'm not sure why this is called "memory.py". Care to elaborate?

chipx86 Nov. 17, 2013, 1:58 p.m.

As discussed in person, the idea was to convey this was for memory-based caching (locmem/memcached), as opposed to client-side/browser caching, or (possibly later) more specific things like redis-based caching.

I'm open to suggestions on the naming.

david Nov. 17, 2013, 1:59 p.m.
```
backend? server?
```

chipx86 Nov. 17, 2013, 6:10 p.m.

I considered backend originally, but typically in Django apps, "backend" modules are internal and used to provide a backend to something, rather than being something you import from. I like it better than "server," though, since that feels more like a server implementation.

djblets/siteconfig/context_processors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
underscores?
```
djblets/urls/context_processors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
underscores?
```

Change Summary:


Replaced camelCase context processor names with underscore_case.

Diff:

Revision 2 (+1235 -1056)

Show changes

	djblets/auth/forms.py
	djblets/auth/views.py
	djblets/cache/backend_compat.py
	djblets/cache/context_processors.py
	djblets/cache/errors.py
	djblets/cache/memory.py
	djblets/cache/serials.py
	djblets/db/evolution.py
	39 more

Change Summary:

Renamed djblets.cache.memory to djblets.cache.backend.

Diff:

Revision 3 (+1235 -1056)

Show changes

	djblets/auth/forms.py
	djblets/auth/views.py
	djblets/cache/backend.py
	djblets/cache/backend_compat.py
	djblets/cache/context_processors.py
	djblets/cache/errors.py
	djblets/cache/serials.py
	djblets/db/evolution.py
	39 more

Ship it!

```
Ship It!
```

Status:: Completed