-
-
-
-
-
-
reviewboard/scmtools/bzr.py (Diff revision 1) Mind documenting why we're doing this?
Think I'd also prefer we pull out uses_netloc from the appropriate module, and then extend it only once.
-
reviewboard/scmtools/git.py (Diff revision 1) Same comment here about docs and extending once.
Actually, given that we're doing this multiple times, I think a better option is to have a utility function that wraps this logic for us that we can just reuse.
-
Use the more modern six library to handle urllib, cStringIO, and cPickle.
Review Request #4936 — Created Nov. 11, 2013 and submitted
Use the more modern six library to handle
urllib,cStringIO, andcPickle.The
urlparse,urllib, andurllib2modules have been significantly reworked in
Python 3 to provide a much more consistent interface.Additionally, the 'fast' versions of
StringIOandpickleare now merged with
the 'slow' versions, so in the future we'll be able to just useio.StringIOand
picklewithout the fallbacks.'six' has some adaptations to help with this for the time being. It's not as
pretty as I would like, but it works. The ugliest part of this is for places
where we overridenetloc\_uses, which isn't among the "moved attributes" in six.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
compat should be after cache. |
 chipx86
|
|
|
error before parse. |
chipx86
|
|
|
error before parse. |
chipx86
|
|
|
util after siteconfig. |
chipx86
|
|
|
Mind documenting why we're doing this? Think I'd also prefer we pull out uses_netloc from the appropriate module, and then … |
chipx86
|
|
|
Same comment here about docs and extending once. Actually, given that we're doing this multiple times, I think a better … |
chipx86
|
|
|
Same here. |
chipx86
|
