Switch to django's built-in login_required decorator.

Review Request #4932 — Created Nov. 10, 2013 and submitted

Information

Review Board
master

Reviewers

Switch to django's built-in login_required decorator.

There's no longer any reason for us to have our own login_required decorator,
and it's just more code for us to maintain. The upstream django one provides
everything we need (plus some nice checking that we didn't have).

This is a little bit ugly because of the name of the 'next_page' field on the
login page, but that will be a trivial cleanup once this goes in.

Checked that all the views which explicitly used login_required and a few of
the views that used check_login_required correctly redirected to the login page
with next_page set properly. Once there, checked that logging in redirected to
the correct page.

Description From Last Updated

Looks like you accidentally a letter.

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/accounts/views.py (Diff revision 1)
     
     

    Looks like you accidentally a letter.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (44bcd10)
Loading...