Improve and fix a couple things in inlineEditor.

Review Request #4918 — Created Nov. 8, 2013 and submitted

Information

Djblets
master

Reviewers

Improve and fix a couple things in inlineEditor.

This adds a 'title' attribute to the "required" asterisk that says "This
field is required."

It also fixes a bug with setting the width of the editor when the
content wraps. We were previously setting min-width, and I believe this
was from before we properly fixed all the width calculations (to ensure
we had a minimum, and didn't have it shrink unintentionally). Removing
the min-width setting doesn't seem to negatively impact any cases where
we've used an inlineEditor.

Hovered over an asterisk and saw the tooltip.

Tested every inlineEditor I could find, with different sizes and with/without
OK/Cancel buttons enabled, and didn't see any breakages.

Description From Last Updated

Hmm. We don't translate anything in djblets, do we...

daviddavid
david
  1. 
      
  2. Show all issues

    Hmm. We don't translate anything in djblets, do we...

    1. We don't. I'd rather that be a separate task than to start with just this.

    2. Sure. Ship it.

  3. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...