Fix a series of breakages noticed while browsing as anonymous.

Review Request #4896 — Created Nov. 4, 2013 and submitted

Information

Review Board
master

Reviewers

Fix a series of breakages noticed while browsing as anonymous.

While accidentally logged out, I noticed a few breakages with review
requests.

First off, everything was editable, and many things were not responding
or loading correctly. This was due to a misplaced </div>, which caused
elements to not appear where they were expected, breaking a bunch of
lookups. That has been fixed.

One glaring problem was that the expand/collapse buttons were flat-out
missing. This is actually noticed while loading any review request at
first, until the JavaScript loads. This was easily fixed by giving them
default icons matching their initial state.

I was also able to edit (or attempt to edit) review requests. Our
'editable' state only considered whether the review request was opened
or closed, not whether the user had access. It now considers whether the
requesting user has edit permissions or owns it.

Browsed around as an anonymous user, as a logged in user with edit
access, and as an anonymous user without edit access.

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...