(enhancement) allow management commands inside RB extensions

Review Request #4837 — Created Oct. 23, 2013 and discarded

Information

Review Board

Reviewers

Now rbsite picks up management commands only from installed applications, i.e. rbsite doesn't take extensions into account. To fix it, rbsite can load all extensions before generating list of management commands.


 
Description From Last Updated

Spaces around =

chipx86chipx86
chipx86
  1. I need to know more about all the testing you're doing. run_manage_command is called in many places, and each one needs to work. By loading extensions in all the codepaths that call run_manage_command, we may inadvertently break things.

    I think I'd feel more comfortable if this were initialized in ManageCommand, and not in run_manage_command. It should also use the reviewboard.initialize function in this case, and not explicitly load the extensions manager.

  2. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     

    Spaces around =

  3. 
      
MI
Review request changed

Status: Discarded

Change Summary:

Seemingly abandoned.
Loading...