Summary

(enhancement) allow management commands inside RB extensions

Review Request #4837 — Created Oct. 23, 2013 and discarded April 25, 2014, 5:06 p.m.

Information

Owner

mizhka

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Now rbsite picks up management commands only from installed applications, i.e. rbsite doesn't take extensions into account. To fix it, rbsite can load all extensions before generating list of management commands.

Testing Done

Issues

Description	From	Last Updated
Spaces around =	chipx86	Oct. 24, 2013, 1:04 a.m.

Fix it!

I need to know more about all the testing you're doing. run_manage_command is called in many places, and each one needs to work. By loading extensions in all the codepaths that call run_manage_command, we may inadvertently break things.
I think I'd feel more comfortable if this were initialized in ManageCommand, and not in run_manage_command. It should also use the reviewboard.initialize function in this case, and not explicitly load the extensions manager.

reviewboard/cmdline/rbsite.py (Diff revision 1)
An issue was opened. Show all issues
```
Spaces around =
```

Status:: Discarded
Change Summary:: Seemingly abandoned.