• 
      

    Fix updating the favicon when there's a notification.

    Review Request #4807 — Created Oct. 19, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Fix updating the favicon when there's a notification.

    The rewritten code to update the favicon for notifications never worked.
    This was due partly to invalid variable names, and partly due to using
    the wrong 'rel' attribute.

    Now, the favicon updates properly when there's a notification, and
    reverts when clicking Ignore.

    Simulated a notification and saw the icon update. Clicked Ignore and saw
    it go back to the standard favicon.

    reviewbot
    1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
      reviewboard/static/rb/js/pages/views/reviewablePageView.js

    2. 
        
    reviewbot
    1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      Ignored Files:
      reviewboard/static/rb/js/pages/views/reviewablePageView.js

    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed