Fix inlineEditor dirty detection with hasRawValue.

Review Request #4802 — Created Oct. 18, 2013 and submitted

chipx86
Djblets
master
djblets

Fix inlineEditor dirty detection with hasRawValue.

When hasRawValue is true, and the current value has any otherwise
HTML-escapable content, the field would always be dirty after any key
press. Simply moving the cursor would mark it as dirty.

We now only htmlEncode the current value if hasRawValue is false.

Moved the cursor around my Markdown document, which had a for loop in it
(and thus a "<"). It didn't ask me to confirm when I hit Escape.

Entered some new text and hit Escape, and it did ask me to confirm.

reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    Ignored Files:
    djblets/static/djblets/js/jquery.gravy.inlineEditor.js

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    Ignored Files:
    djblets/static/djblets/js/jquery.gravy.inlineEditor.js

  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...