WIP: Add the Trophy model to represent a trophy.

 






 

 


  Review Request #4789
  —
  Created Oct. 17, 2013 and discarded 

 


















 

  

   Information

  





 
 

  bzd
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Add the Trophy model to represent a trophy.

 








  


 
 

  
No testing done yet.

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
We're going to want you to generate a new evolution for this new model. See http://www.reviewboard.org/docs/codebase/dev/tasks/database-evolutions/

      		
      
       mike_conleymike_conley
      
      
       
      
     




     

      
       
       
These newlines are no longer needed.

      		
      
       mike_conleymike_conley
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




mike_conley




   

   







  

 



 

  


   

   

    
 
mike_conley


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/accounts/models.py
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    We're going to want you to generate a new evolution for this new model.
    

    See http://www.reviewboard.org/docs/codebase/dev/tasks/database-evolutions/
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      New models don't have evolutions. There will need to be evolutions for changes to existing models, though, once those changes are made.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Yikes - shows how long it's been since I made a new model.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      I kind of wish they did. There's some interesting problems that arise when you create a model, change fields a bunch, make evolutions, and then people upgrade to it from an ancient release pre-model. Fortunately those seemed to be fixed in django-evolution, but they were a source of nightmares before.
      
 
      

      4. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/accounts/models.py
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    These newlines are no longer needed.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   





 BZ





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 




 
Change Summary:

 
Looks like this is being continued in /r/4855.





 


 










  

 









     

    

   

  

  

   
   Loading...