Summary

Don't bomb out if a password wasn't provided

Review Request #4787 — Created Oct. 17, 2013 and submitted Oct. 24, 2013, 6:38 p.m.

Information

Owner

yaneurabeya

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The base class can return None if the password attribute is None

Testing Done

rbt post/post-review

Expand All
Collapse All

We're trying to treat post-review as deprecated and avoid making any non-critical changes to it. Does rbt post have the same problem?

yaneurabeya Oct. 21, 2013, 5:01 p.m.

I don't know... long story short is that I was using post-review because I was running into problems when using rbt post. I've started using rbt post exclusively now though, but I forgot the process I used to repro the issue..

Ship it!

I'm going to push this, with a slight change to make postreview.py and api/request.py consistent.

YA

yaneurabeya Oct. 24, 2013, 6:50 p.m.
```
Cool -- thanks :)!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.5.x (0cccdc6). Thanks!