Don't use httplib constants instead of hardcoded values

Review Request #4776 — Created Oct. 16, 2013 and submitted

Information

RBTools
master

Reviewers

Use httplib constants instead of hardcoded values.

I've been using rbm post / post-review.

Description From Last Updated

The error code here isn't an HTTP error, it's a Review Board API error. We should probably have a list …

daviddavid
david
  1. It might be nice to split this up into two separate changes, since right now this is doing two unrelated things.

  2. rbtools/postreview.py (Diff revision 1)
     
     
    Show all issues

    The error code here isn't an HTTP error, it's a Review Board API error. We should probably have a list of the errors in rbtools/api/errors.py and use that instead of hardcoding the value.

  3. 
      
YA
david
  1. Ship It!

  2. 
      
YA
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (93fae50). Thanks!

Loading...