Summary

Don't use httplib constants instead of hardcoded values

Review Request #4776 — Created Oct. 16, 2013 and submitted Oct. 18, 2013, 2:02 p.m.

Information

Owner

yaneurabeya

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Use httplib constants instead of hardcoded values.

Testing Done

I've been using rbm post / post-review.

Issues

Description	From	Last Updated
The error code here isn't an HTTP error, it's a Review Board API error. We should probably have a list …	david	Oct. 17, 2013, 9:27 a.m.

It might be nice to split this up into two separate changes, since right now this is doing two unrelated things.

rbtools/postreview.py (Diff revision 1)

The issue has been resolved. Show all issues

The error code here isn't an HTTP error, it's a Review Board API error. We should probably have a list of the errors in rbtools/api/errors.py and use that instead of hardcoding the value.

Summary:

Don't use httplib constants instead of hardcoded values / don't bomb if a password wasn't provided in ReviewBoardHTTPBasicAuthHandler.retry_http_basic_auth

Don't use httplib constants instead of hardcoded values

Description:

~		Use httplib constants instead of hardcoded values.
	~	Use httplib constants instead of hardcoded values.
-		Don't bomb out if a password wasn't provided in ReviewBoardHTTPBasicAuthHandler.retry_http_basic_auth as response can be None in that event.

Diff:

Revision 2 (+6 -6)

Show changes

rbtools/postreview.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (93fae50). Thanks!