Summary

Strip off #index_header before starting the diff router.

Review Request #4701 — Created Oct. 8, 2013 and submitted Oct. 8, 2013, 8:25 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Strip off #index_header before starting the diff router.

Backbone's router will turn hashes into URL components. This is a problem for
the diff page, which uses #index_header to jump past the review request
details. I've added some code to strip out the hash before we start Backbone's
history tracking, which fixes the URL.

Testing Done

Loaded /diff/#index_header and saw that the URL changed to /diff/# instead of
/diff/index_header.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
Ignored Files:
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
Ignored Files:
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

Ship it!

Ship It!

chipx86 Oct. 8, 2013, 7:57 p.m.

Before you commit, though, please test with IE, Firefox, Chrome and Safari, and make sure it works. I don't know if you can set window.hash everywhere.

Status: Closed (submitted)

Change Summary:

Pushed to master (0853b22).