Add extra_data support to all comment types.

Review Request #4697 — Created Oct. 8, 2013 and submitted

chipx86
Review Board
master
reviewboard

Add extra_data support to all comment types.

FileAttachmentComment had an extra_data field and API support for
setting it, which was handy, but this can be handy for other comment
types as well.

This support now exists in BaseComment, and all comment REST API support
has been updated to allow getting and setting it.

While I was at it, I moved some of the common field definitions into
BaseCommentResource, instead of duplicating it in the other base comment
subclasses.

All unit tests, new ones including, pass.

Description From Last Updated

This will end up saving twice. It might be nicer to instantiate the comment object directly instead of using RelatedManager's ...

daviddavid

Same here re: saving

daviddavid
david
  1. 
      
  2. reviewboard/testing/testcase.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    This will end up saving twice. It might be nicer to instantiate the comment object directly instead of using RelatedManager's create().

  3. reviewboard/testing/testcase.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Same here re: saving

  4. 
      
chipx86
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...