Fix datagrid pagination on Django 1.5.

Review Request #4686 — Created Oct. 6, 2013 and submitted

chipx86
Djblets
master
djblets

Fix datagrid pagination on Django 1.5.

Django 1.5 didn't like how we were attempting to access a variable in
the context that didn't exist, and would fail with a traceback.

We now guarantee that these variables always exist.

I could see the datagrid again, instead of a big exception, when it was
paginating.

Description From Last Updated

It might be nice to use the ternary syntax here.

daviddavid
david
  1. 
      
  2. djblets/datagrid/grids.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     

    It might be nice to use the ternary syntax here.

    1. I must admit, I hate that syntax in Python.

    2. If I use that syntax, it becomes multiple lines anyway, due to line lengths.

    3. Fair enough. Ship it.

  3. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...