Summary

Fix datagrid pagination on Django 1.5.

Review Request #4686 — Created Oct. 6, 2013 and submitted Oct. 9, 2013, 12:15 a.m.

Owner

Repository

Djblets

Branch

master

Bugs

Depends On

Groups

People

Description

Fix datagrid pagination on Django 1.5.

Django 1.5 didn't like how we were attempting to access a variable in
the context that didn't exist, and would fail with a traceback.

We now guarantee that these variables always exist.

Testing Done

I could see the datagrid again, instead of a big exception, when it was
paginating.

Issues

Description	From	Last Updated
It might be nice to use the ternary syntax here.	david	Oct. 9, 2013, 12:15 a.m.

djblets/datagrid/grids.py (Diff revision 1)

The issue has been dropped. Show all issues

It might be nice to use the ternary syntax here.

I must admit, I hate that syntax in Python.

If I use that syntax, it becomes multiple lines anyway, due to line lengths.