• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Remove a bunch of hacks and quirks from jquery.gravy
    
 
    

    



 
    
 
    

  Review Request #4678
  —
  Created Oct. 3, 2013 and submitted 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Djblets
 
    

    





    
 
 
    
  master
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  djblets
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    Remove a bunch of hacks and quirks from jquery.gravy
    

    We have a number of hacks and workarounds for old versions of web browsers
    
(mostly IE6). Since we no longer support these very old browsers, we can clean
    
a lot of this up. My goal here is to eliminate reliance on $.browser, since
    
that's blocking us from upgrading to more recent versions of jquery.
    

    The one hack that I didn't remove from djblets is a fix for the innerHTML quirk
    
in IE. This quirk was fixed in IE9, but for now we still want to maintain
    
compatibility with IE8.
    
 
    

    





  

    
 
 
    
  
    Smoke tested changes in a few different browsers. Checked that hover for
    
tooltips still worked.
    
 
    

    




 
    

    





    
 
    









 









 
    

    



  
    
 
    

    


    


 













    
 





 
    
  
    
   
    



reviewbot




   
    
   
    



    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
reviewbot


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      This is a review from Review Bot.
      
  Tool: PEP8 Style Checker
      
  Processed Files:
      
  Ignored Files:
      
    djblets/static/djblets/js/jquery.gravy.modalBox.js
      
    djblets/static/djblets/js/jquery.gravy.util.js
      
    djblets/static/djblets/js/jquery.gravy.inlineEditor.js
      
    djblets/static/djblets/js/jquery.gravy.hacks.js
      
    djblets/static/djblets/js/jquery.gravy.tooltip.js
      
    djblets/static/djblets/js/jquery.gravy.autosize.js
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 





 
    
  
    
   
    



reviewbot




   
    
   
    



    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
reviewbot


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      This is a review from Review Bot.
      
  Tool: Pyflakes
      
  Processed Files:
      
  Ignored Files:
      
    djblets/static/djblets/js/jquery.gravy.modalBox.js
      
    djblets/static/djblets/js/jquery.gravy.util.js
      
    djblets/static/djblets/js/jquery.gravy.inlineEditor.js
      
    djblets/static/djblets/js/jquery.gravy.hacks.js
      
    djblets/static/djblets/js/jquery.gravy.tooltip.js
      
    djblets/static/djblets/js/jquery.gravy.autosize.js
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       djblets/static/djblets/js/jquery.gravy.hacks.js
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      I don't remember why I didn't define this conditionally based on browser version, but maybe we should do that? One fewer set of calls when doing html().
      

      Not saying you have to do this, but just mentioning it for now.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 




    3. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to master (97b7592).