Ignore stderr with 'svn propget reviewboard:url .

Review Request #4670 — Created Oct. 1, 2013 and submitted

Information

RBTools
master

Reviewers

On my system the local en_US.UTF-8 does not exist (I have he_IL.UTF-8). rbutils.utils.process.execute() forces the environment to be LC_ALL=en_US.UTF-8, LANGUAGE=en_US.UTF-8. I can't override this from outside. This means that svn will complain to the standad error about not being able to set LC_CTYPE.

Furthermore, by default that function (execute()) will redirect stderr with stdout. This resulted in the reviewbord server being '<long message from svn><the URL>'.

This fix forces not redirecting the standard error there. Though just in this specific spot.


 
Description From Last Updated

Col: 80 E501 line too long (97 > 79 characters)

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    rbtools/clients/svn.py
    Ignored Files:

  2. rbtools/clients/svn.py (Diff revision 1)
     
     

    Col: 80
    E501 line too long (97 > 79 characters)

  3. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    rbtools/clients/svn.py
    Ignored Files:

  2. 
      
david
  1. Ship It!
  2. 
      
TZ
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.5.x (06ec2cd).
Loading...