post-review for P4win
Review Request #467 — Created July 24, 2008 and submitted
Information | |
---|---|
JSlominski | |
Review Board SVN (deprecated) | |
Reviewers | |
reviewboard | |
I have updated post-review to set the proper perforce environment. Before P4Tool.txt is imported into P4win, the user needs to enter the path of post-review. After it is imported they should be able to right click on any change list and by clicking post-review, post a review of the change list in perforce.
-
-
-
/trunk/reviewboard/contrib/tools/post-review (Diff revision 3) You should be using isinstance() here.
-
/trunk/reviewboard/contrib/tools/post-review (Diff revision 3) I'd prefer --p4-client and --p4-port. The variable names should be p4_client and p4_port too.
-
/trunk/reviewboard/contrib/tools/post-review (Diff revision 3) I'd rather we not abbreviate "CL". This is more generic than changelists, so let's just say something like "the Perforce client name" and "the Perforce server address" or something.
-
Thanks, committed as r1550. I don't use Windows and therefore don't use P4win, so I can't test this, but what happens if you need to log in? Does P4win provide any sort of a terminal UI where you can input this information, and does it show the resulting URL? We may want to modify this to use -o (for opening a web browser) after this is posted.