Summary

Add Google and GitHub auth support

Review Request #4666 — Created Sept. 29, 2013 and discarded April 23, 2014, 3:34 p.m.

Information

Owner

puiterwijk

Repository

Review Board

Branch

master

Bugs

Depends On

~~4641~~

Reviewers

Groups

reviewboard

People

Description

Add Google and GitHub auth support

Testing Done

Issues

Description	From	Last Updated
Col: 80 E501 line too long (108 > 79 characters)	reviewbot	Sept. 29, 2013, 4:02 p.m.
'DNS' imported but unused	reviewbot	Sept. 29, 2013, 4 p.m.
'S3BotoStorage' imported but unused	reviewbot	Sept. 29, 2013, 4 p.m.
'CouchDBStorage' imported but unused	reviewbot	Sept. 29, 2013, 4 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Sept. 29, 2013, 4 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Sept. 29, 2013, 4 p.m.
Col: 37 E241 multiple spaces after ':'	reviewbot	Sept. 29, 2013, 4 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Sept. 29, 2013, 4:04 p.m.
'DNS' imported but unused	reviewbot	Sept. 29, 2013, 4:04 p.m.
'S3BotoStorage' imported but unused	reviewbot	Sept. 29, 2013, 4:04 p.m.
'CouchDBStorage' imported but unused	reviewbot	Sept. 29, 2013, 4:04 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Sept. 29, 2013, 4:04 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Sept. 29, 2013, 4:04 p.m.
Col: 37 E241 multiple spaces after ':'	reviewbot	Sept. 29, 2013, 4:04 p.m.
'DNS' imported but unused	reviewbot	Sept. 29, 2013, 4:06 p.m.
'S3BotoStorage' imported but unused	reviewbot	Sept. 29, 2013, 4:06 p.m.
'CouchDBStorage' imported but unused	reviewbot	Sept. 29, 2013, 4:06 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Sept. 29, 2013, 4:06 p.m.
Col: 26 E241 multiple spaces after ':'	reviewbot	Sept. 29, 2013, 4:06 p.m.
Col: 37 E241 multiple spaces after ':'	reviewbot	Sept. 29, 2013, 4:06 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/admin/checks.py
reviewboard/admin/siteconfig.py
reviewboard/accounts/forms.py
Ignored Files:
reviewboard/templates/accounts/prefs.html
reviewboard/templates/accounts/login.html

reviewboard/accounts/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80

 E501 line too long (108 > 79 characters)
```
reviewboard/admin/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 26

 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 26

 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 37

 E241 multiple spaces after ':'
```

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/admin/checks.py
reviewboard/admin/siteconfig.py
reviewboard/accounts/forms.py
Ignored Files:
reviewboard/templates/accounts/prefs.html
reviewboard/templates/accounts/login.html

reviewboard/admin/checks.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'DNS' imported but unused
```
reviewboard/admin/checks.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'S3BotoStorage' imported but unused
```
reviewboard/admin/checks.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'CouchDBStorage' imported but unused
```

Change Summary:

Split line to be conforming to PEP8.

Depends On:

-	~~4641 - Adds OpenID authentication support~~

Diff:

Revision 2 (+138 -55)

Show changes

	reviewboard/accounts/forms.py
	reviewboard/admin/checks.py
	reviewboard/admin/siteconfig.py
	reviewboard/templates/accounts/login.html
	reviewboard/templates/accounts/prefs.html

reviewboard/accounts/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 13

 E128 continuation line under-indented for visual indent
```
reviewboard/admin/siteconfig.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 26

 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 26

 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 37

 E241 multiple spaces after ':'
```

reviewboard/admin/checks.py (Diff revision 2)
The issue has been dropped. Show all issues
```
'DNS' imported but unused
```
reviewboard/admin/checks.py (Diff revision 2)
The issue has been dropped. Show all issues
```
'S3BotoStorage' imported but unused
```
reviewboard/admin/checks.py (Diff revision 2)
The issue has been dropped. Show all issues
```
'CouchDBStorage' imported but unused
```

Diff:

Revision 3 (+138 -55)

Show changes

	reviewboard/accounts/forms.py
	reviewboard/admin/checks.py
	reviewboard/admin/siteconfig.py
	reviewboard/templates/accounts/login.html
	reviewboard/templates/accounts/prefs.html

reviewboard/admin/siteconfig.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 26

 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 26

 E241 multiple spaces after ':'
```
reviewboard/admin/siteconfig.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 37

 E241 multiple spaces after ':'
```

reviewboard/admin/checks.py (Diff revision 3)
The issue has been dropped. Show all issues
```
'DNS' imported but unused
```
reviewboard/admin/checks.py (Diff revision 3)
The issue has been dropped. Show all issues
```
'S3BotoStorage' imported but unused
```
reviewboard/admin/checks.py (Diff revision 3)
The issue has been dropped. Show all issues
```
'CouchDBStorage' imported but unused
```

Depends On:

+	~~4641 - Adds OpenID authentication support~~

Status: Discarded

Change Summary:

Discarded in favor of https://reviews.reviewboard.org/r/5199/

reviewboard/admin/checks.py (Diff revision 1)

reviewboard/admin/checks.py (Diff revision 1)

reviewboard/admin/checks.py (Diff revision 1)

reviewboard/admin/checks.py (Diff revision 2)