Add Google and GitHub auth support

Review Request #4666 — Created Sept. 29, 2013 and discarded

Information

Review Board
master

Reviewers

Add Google and GitHub auth support


 
Description From Last Updated

Col: 80 E501 line too long (108 > 79 characters)

reviewbotreviewbot

'DNS' imported but unused

reviewbotreviewbot

'S3BotoStorage' imported but unused

reviewbotreviewbot

'CouchDBStorage' imported but unused

reviewbotreviewbot

Col: 26 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 26 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 37 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 13 E128 continuation line under-indented for visual indent

reviewbotreviewbot

'DNS' imported but unused

reviewbotreviewbot

'S3BotoStorage' imported but unused

reviewbotreviewbot

'CouchDBStorage' imported but unused

reviewbotreviewbot

Col: 26 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 26 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 37 E241 multiple spaces after ':'

reviewbotreviewbot

'DNS' imported but unused

reviewbotreviewbot

'S3BotoStorage' imported but unused

reviewbotreviewbot

'CouchDBStorage' imported but unused

reviewbotreviewbot

Col: 26 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 26 E241 multiple spaces after ':'

reviewbotreviewbot

Col: 37 E241 multiple spaces after ':'

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/siteconfig.py
    reviewboard/accounts/forms.py
    Ignored Files:
    reviewboard/templates/accounts/prefs.html
    reviewboard/templates/accounts/login.html

  2. reviewboard/accounts/forms.py (Diff revision 1)
     
     
    Show all issues

    Col: 80
    E501 line too long (108 > 79 characters)

  3. reviewboard/admin/siteconfig.py (Diff revision 1)
     
     
    Show all issues

    Col: 26
    E241 multiple spaces after ':'

  4. reviewboard/admin/siteconfig.py (Diff revision 1)
     
     
    Show all issues

    Col: 26
    E241 multiple spaces after ':'

  5. reviewboard/admin/siteconfig.py (Diff revision 1)
     
     
    Show all issues

    Col: 37
    E241 multiple spaces after ':'

  6. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/siteconfig.py
    reviewboard/accounts/forms.py
    Ignored Files:
    reviewboard/templates/accounts/prefs.html
    reviewboard/templates/accounts/login.html

  2. reviewboard/admin/checks.py (Diff revision 1)
     
     
    Show all issues

    'DNS' imported but unused

  3. reviewboard/admin/checks.py (Diff revision 1)
     
     
    Show all issues

    'S3BotoStorage' imported but unused

  4. reviewboard/admin/checks.py (Diff revision 1)
     
     
    Show all issues

    'CouchDBStorage' imported but unused

  5. 
      
PU
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/siteconfig.py
    reviewboard/accounts/forms.py
    Ignored Files:
    reviewboard/templates/accounts/prefs.html
    reviewboard/templates/accounts/login.html

  2. reviewboard/accounts/forms.py (Diff revision 2)
     
     
    Show all issues

    Col: 13
    E128 continuation line under-indented for visual indent

  3. reviewboard/admin/siteconfig.py (Diff revision 2)
     
     
    Show all issues

    Col: 26
    E241 multiple spaces after ':'

  4. reviewboard/admin/siteconfig.py (Diff revision 2)
     
     
    Show all issues

    Col: 26
    E241 multiple spaces after ':'

  5. reviewboard/admin/siteconfig.py (Diff revision 2)
     
     
    Show all issues

    Col: 37
    E241 multiple spaces after ':'

  6. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/siteconfig.py
    reviewboard/accounts/forms.py
    Ignored Files:
    reviewboard/templates/accounts/prefs.html
    reviewboard/templates/accounts/login.html

  2. reviewboard/admin/checks.py (Diff revision 2)
     
     
    Show all issues

    'DNS' imported but unused

  3. reviewboard/admin/checks.py (Diff revision 2)
     
     
    Show all issues

    'S3BotoStorage' imported but unused

  4. reviewboard/admin/checks.py (Diff revision 2)
     
     
    Show all issues

    'CouchDBStorage' imported but unused

  5. 
      
PU
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/siteconfig.py
    reviewboard/accounts/forms.py
    Ignored Files:
    reviewboard/templates/accounts/prefs.html
    reviewboard/templates/accounts/login.html

  2. reviewboard/admin/siteconfig.py (Diff revision 3)
     
     
    Show all issues

    Col: 26
    E241 multiple spaces after ':'

  3. reviewboard/admin/siteconfig.py (Diff revision 3)
     
     
    Show all issues

    Col: 26
    E241 multiple spaces after ':'

  4. reviewboard/admin/siteconfig.py (Diff revision 3)
     
     
    Show all issues

    Col: 37
    E241 multiple spaces after ':'

  5. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/admin/checks.py
    reviewboard/admin/siteconfig.py
    reviewboard/accounts/forms.py
    Ignored Files:
    reviewboard/templates/accounts/prefs.html
    reviewboard/templates/accounts/login.html

  2. reviewboard/admin/checks.py (Diff revision 3)
     
     
    Show all issues

    'DNS' imported but unused

  3. reviewboard/admin/checks.py (Diff revision 3)
     
     
    Show all issues

    'S3BotoStorage' imported but unused

  4. reviewboard/admin/checks.py (Diff revision 3)
     
     
    Show all issues

    'CouchDBStorage' imported but unused

  5. 
      
PU
PU
Review request changed
Status:
Discarded
Change Summary:
Discarded in favor of https://reviews.reviewboard.org/r/5199/