Summary

Fix the Watched Review Request resource with local sites, and add tests.

Review Request #4658 — Created Sept. 28, 2013 and submitted Oct. 11, 2013, 9:32 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix the Watched Review Request resource with local sites, and add tests.

The GET handler for the Watched Review Request resource didn't accept
local IDs for review requests, causing it to be pretty useless there.
Now it takes the proper IDs.

Unit tests were added for this, and for all other missing cases.

Testing Done

Unit tests pass. The newly added tests failed before this change.

Issues

Description	From	Last Updated
local variable 'expected_url' is assigned to but never used	reviewbot	Oct. 5, 2013, 5:10 a.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/webapi/tests/base.py
reviewboard/webapi/resources/watched_review_request.py
reviewboard/webapi/resources/base_watched_object.py
reviewboard/webapi/tests/test_watched_review_request.py
Ignored Files:

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/webapi/tests/base.py
reviewboard/webapi/resources/watched_review_request.py
reviewboard/webapi/resources/base_watched_object.py
reviewboard/webapi/tests/test_watched_review_request.py
Ignored Files:

reviewboard/webapi/tests/test_watched_review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
local variable 'expected_url' is assigned to but never used
```

Ship it!

After fixing ReviewBot's comment, looks good.

Status:: Completed