Fix the Watched Review Request resource with local sites, and add tests.

Review Request #4658 — Created Sept. 28, 2013 and submitted

chipx86
Review Board
master
reviewboard

Fix the Watched Review Request resource with local sites, and add tests.

The GET handler for the Watched Review Request resource didn't accept
local IDs for review requests, causing it to be pretty useless there.
Now it takes the proper IDs.

Unit tests were added for this, and for all other missing cases.

Unit tests pass. The newly added tests failed before this change.

Description From Last Updated

local variable 'expected_url' is assigned to but never used

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/watched_review_request.py
    reviewboard/webapi/resources/base_watched_object.py
    reviewboard/webapi/tests/test_watched_review_request.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/webapi/tests/base.py
    reviewboard/webapi/resources/watched_review_request.py
    reviewboard/webapi/resources/base_watched_object.py
    reviewboard/webapi/tests/test_watched_review_request.py
    Ignored Files:

  2. local variable 'expected_url' is assigned to but never used

  3. 
      
david
  1. After fixing ReviewBot's comment, looks good.

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...