Summary

Update for the changes to djblets static media.

Review Request #4655 — Created Sept. 27, 2013 and submitted Oct. 1, 2013, 3:34 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Update for the changes to djblets static media.
This pulls in the stuff required from the djblets static media move. Part of

this means that we'll re-ship the djblets media as part of the Review Board

package, but that's fine.

Testing Done


Verified that pages like the dashboard and extension list still worked and

  looked correct.
Ran build-media.py and checked the results.

Issues

Description	From	Last Updated
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 27, 2013, 5:10 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 30, 2013, 11:28 a.m.
Indent the "{% compressed... %}"	chipx86	Oct. 1, 2013, 3:22 p.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/settings.py
Ignored Files:
reviewboard/templates/reviews/dashboard.html
reviewboard/templates/reviews/datagrid.html
reviewboard/templates/base.html

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/settings.py
Ignored Files:
reviewboard/templates/reviews/dashboard.html
reviewboard/templates/reviews/datagrid.html
reviewboard/templates/base.html

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

Shouldn't this be blocked by #4654 for the record?

Change Summary:

Add dependency

Depends On:

+	~~4654 - Move static media to static/ and start compiling it.~~

Depends On:

-	~~4654 - Move static media to static/ and start compiling it.~~

Diff:

Revision 2 (+26 -28)

Show changes

	reviewboard/settings.py
	reviewboard/templates/base.html
	reviewboard/templates/reviews/dashboard.html
	reviewboard/templates/reviews/datagrid.html

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

Ship it!

```
One trivial change, then ship it!
```
reviewboard/templates/reviews/datagrid.html (Diff revision 2)
The issue has been resolved. Show all issues
```
Indent the "{%  compressed... %}"
```

Status: Closed (submitted)

Change Summary:

Pushed to master (55f66a8).

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 2)