• 
      

    Pull 1.7 release notes images into the docs tree.

    Review Request #4646 — Created Sept. 25, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Pull 1.7 release notes images into the docs tree.

    The images used for the 1.7 release notes were all hosted on reviewboard.org.
    This was both annoying in terms of things being self-contained (we'd have to go
    upload things separately from writing the docs), and the format of them was
    pretty bad when building the docs to a format other than HTML.

    I've downloaded all of the images and referenced them locally instead of
    remotely. In addition, I've added some conditionals to include the full images
    when the target isn't HTML and fixed the latex target.

    • Built the HTML docs and verified that the thumbnails showed up, and that
      links to the full versions went to the correct place.
    • Built the latex docs, compiled to PDF, and verified that the full screenshots
      were included rather than the thumbnails.
    reviewbot
    1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      docs/releasenotes/conf.py
      Ignored Files:
      docs/releasenotes/1.7.txt
      docs/releasenotes/_static/images/1.7/file-attachments_thumb.png
      docs/releasenotes/_static/images/1.7/extensions.png
      docs/releasenotes/_static/images/1.7/image-review_thumb.png
      docs/releasenotes/_static/images/1.7/admin-ui.png
      docs/releasenotes/_static/images/1.7/issue-summary.png
      docs/releasenotes/_static/images/1.7/admin-ui_thumb.png
      docs/releasenotes/_static/images/1.7/image-review.png
      docs/releasenotes/_static/images/1.7/file-attachments.png
      docs/releasenotes/_static/images/1.7/issue-summary_thumb.png
      docs/releasenotes/_static/images/1.7/extensions_thumb.png

    2. 
        
    reviewbot
    1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
      docs/releasenotes/conf.py
      Ignored Files:
      docs/releasenotes/1.7.txt
      docs/releasenotes/_static/images/1.7/file-attachments_thumb.png
      docs/releasenotes/_static/images/1.7/extensions.png
      docs/releasenotes/_static/images/1.7/image-review_thumb.png
      docs/releasenotes/_static/images/1.7/admin-ui.png
      docs/releasenotes/_static/images/1.7/issue-summary.png
      docs/releasenotes/_static/images/1.7/admin-ui_thumb.png
      docs/releasenotes/_static/images/1.7/image-review.png
      docs/releasenotes/_static/images/1.7/file-attachments.png
      docs/releasenotes/_static/images/1.7/issue-summary_thumb.png
      docs/releasenotes/_static/images/1.7/extensions_thumb.png

    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:

    Pushed to master (50c03cf).