Move DiffFileIndexView out into its own file.

Review Request #4642 — Created Sept. 24, 2013 and submitted

Information

Review Board
master

Reviewers

Move DiffFileIndexView out into its own file.

This isn't used anywhere except the DiffViewerPageView, but neither are any of
the other views that make up the diff viewer, and the page view implementation
is a pretty big file.

Smoke tested the diff viewer.

Description From Last Updated

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/settings.py
    Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/settings.py
    Ignored Files:
    reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

  2. reviewboard/settings.py (Diff revision 1)
     
     

    'from settings_local import *' used; unable to detect undefined names

  3. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (c4a1c54).

Loading...