Fix a Mercurial crash with 'hg outgoing' and only warnings.

Review Request #4637 — Created Sept. 23, 2013 and submitted

chipx86
RBTools
master
rbtools

Fix a Mercurial crash with 'hg outgoing' and only warnings.

When trying to post without any outgoing changes, and with warnings
(for, say, unverified HTTPS certificates), things would crash. It
assumed if there was any output, there would be at least one non-warning
line, but this isn't always safe. We now check for this.

Ran 'rbt post' in a newly checked out repo, cloned from an HTTPS repo.
Instead of crashing with a ValueError, I got a proper error saying that
there weren't any modified files.

reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    rbtools/clients/mercurial.py
    Ignored Files:

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    rbtools/clients/mercurial.py
    Ignored Files:

  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...