Move the "You have comments in other revisions" blob into javascript.

Review Request #4626 — Created Sept. 21, 2013 and submitted

Information

Review Board
master

Reviewers

Move the "You have comments in other revisions" blob into javascript.

This change drives the rendering of the info box for comments in other revisions
from javascript instead of HTML. This is the last piece of the diffviewer
needed before I can do dynamic updates.

  • Created draft comments on several diff and interdiff revisions and verified
    that it appeared correctly.
  • Tested in conjunction with my change for dynamic updates.
  • Ran unit tests.
Description From Last Updated

'DiffSet' imported but unused

reviewbotreviewbot

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

Since this code is being reintroduced in a new place, can you fix up the docstring for the proper format?

chipx86chipx86

Here too.

chipx86chipx86

Here too.

chipx86chipx86

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

Should go above initialize.

chipx86chipx86

Can you use a template for this?

chipx86chipx86

We can speed this function up by calling gettext(...) before the loop.

chipx86chipx86

Same here.

chipx86chipx86

Blank line after vars.

chipx86chipx86

Here too.

chipx86chipx86

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/context.py
    Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
    reviewboard/static/rb/css/diffviewer.less
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/context.py
    Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
    reviewboard/static/rb/css/diffviewer.less
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

  2. 'DiffSet' imported but unused

  3. reviewboard/settings.py (Diff revision 1)
     
     

    'from settings_local import *' used; unable to detect undefined names

  4. 
      
david
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/context.py
    Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
    reviewboard/static/rb/css/diffviewer.less
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

  2. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/context.py
    Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
    reviewboard/static/rb/css/diffviewer.less
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

  2. reviewboard/settings.py (Diff revision 2)
     
     

    'from settings_local import *' used; unable to detect undefined names

  3. 
      
chipx86
  1. 
      
  2. reviewboard/reviews/context.py (Diff revision 2)
     
     
     
     
     

    Since this code is being reintroduced in a new place, can you fix up the docstring for the proper format?

  3. reviewboard/reviews/context.py (Diff revision 2)
     
     
     
     

    Here too.

  4. reviewboard/reviews/context.py (Diff revision 2)
     
     
     
     

    Here too.

  5. Should go above initialize.

  6. reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Can you use a template for this?

  7. We can speed this function up by calling gettext(...) before the loop.

  8. 
      
david
reviewbot
  1. This is a review from Review Bot.
    Tool: PEP8 Style Checker
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/context.py
    Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
    reviewboard/static/rb/css/diffviewer.less
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

  2. reviewboard/reviews/context.py (Diff revision 3)
     
     

    Col: 80
    E501 line too long (81 > 79 characters)

  3. 
      
reviewbot
  1. This is a review from Review Bot.
    Tool: Pyflakes
    Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/context.py
    Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
    reviewboard/static/rb/css/diffviewer.less
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
    reviewboard/static/rb/js/pages/views/diffViewerPageView.js

  2. reviewboard/settings.py (Diff revision 3)
     
     

    'from settings_local import *' used; unable to detect undefined names

  3. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (620640b).

Loading...