Review Request #4626: Move the "You have comments in other revisions" blob into javascript.

Description	From	Last Updated
'DiffSet' imported but unused	reviewbot	Sept. 21, 2013, 2:15 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 21, 2013, 2:08 p.m.
Since this code is being reintroduced in a new place, can you fix up the docstring for the proper format?	chipx86	Sept. 22, 2013, 6:49 a.m.
Here too.	chipx86	Sept. 22, 2013, 6:49 a.m.
Here too.	chipx86	Sept. 22, 2013, 6:49 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 21, 2013, 2:17 p.m.
Should go above initialize.	chipx86	Sept. 22, 2013, 6:49 a.m.
Can you use a template for this?	chipx86	Sept. 22, 2013, 6:58 a.m.
We can speed this function up by calling gettext(...) before the loop.	chipx86	Sept. 22, 2013, 6:58 a.m.
Same here.	chipx86	Sept. 22, 2013, 6:58 a.m.
Blank line after vars.	chipx86	Sept. 22, 2013, 6:58 a.m.
Here too.	chipx86	Sept. 22, 2013, 6:58 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Sept. 22, 2013, 7:28 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Sept. 22, 2013, 7:07 a.m.

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/reviews/views.py
reviewboard/settings.py
reviewboard/reviews/templatetags/reviewtags.py
reviewboard/reviews/context.py
Ignored Files:
reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/reviews/views.py
reviewboard/settings.py
reviewboard/reviews/templatetags/reviewtags.py
reviewboard/reviews/context.py
Ignored Files:
reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'DiffSet' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

Diff:

Revision 2 (+283 -107)

Show changes

	reviewboard/settings.py
	reviewboard/reviews/context.py
	reviewboard/reviews/views.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/css/diffviewer.less
	reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
	reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
	2 more

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/reviews/views.py
reviewboard/settings.py
reviewboard/reviews/templatetags/reviewtags.py
reviewboard/reviews/context.py
Ignored Files:
reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/reviews/views.py
reviewboard/settings.py
reviewboard/reviews/templatetags/reviewtags.py
reviewboard/reviews/context.py
Ignored Files:
reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

reviewboard/reviews/context.py (Diff revision 2)

The issue has been resolved. Show all issues

Since this code is being reintroduced in a new place, can you fix up the docstring for the proper format?

reviewboard/reviews/context.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Here too.
```
reviewboard/reviews/context.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Here too.
```

reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js (Diff revision 2)

The issue has been resolved. Show all issues

Should go above initialize.

reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js (Diff revision 2)

The issue has been resolved. Show all issues

Can you use a template for this?

reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
We can speed this function up by calling gettext(...) before the loop.
```
reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Same here.
```
reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line after vars.
```
reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Here too.
```

Diff:

Revision 3 (+280 -107)

Show changes

	reviewboard/settings.py
	reviewboard/reviews/context.py
	reviewboard/reviews/views.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/css/diffviewer.less
	reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
	reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
	2 more

This is a review from Review Bot.
Tool: PEP8 Style Checker
Processed Files:
reviewboard/reviews/views.py
reviewboard/settings.py
reviewboard/reviews/templatetags/reviewtags.py
reviewboard/reviews/context.py
Ignored Files:
reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

reviewboard/reviews/context.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80

 E501 line too long (81 > 79 characters)
```

This is a review from Review Bot.
Tool: Pyflakes
Processed Files:
reviewboard/reviews/views.py
reviewboard/settings.py
reviewboard/reviews/templatetags/reviewtags.py
reviewboard/reviews/context.py
Ignored Files:
reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.js
reviewboard/static/rb/css/diffviewer.less
reviewboard/templates/diffviewer/view_diff.html
reviewboard/static/rb/js/pages/models/diffViewerPageModel.js
reviewboard/static/rb/js/diffviewer/views/diffCommentsHintView.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.js

reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
'from settings_local import *' used; unable to detect undefined names
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (620640b).

Review Board 7.0.2 alpha 0 (dev)

Move the "You have comments in other revisions" blob into javascript.

Information

Reviewers